Fix HTTPS_PROXY env var #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
approved these changes
Apr 8, 2024
| @@ -108,7 +108,7 @@ def process(self, instance): | |||
| sg_local_storage["mac_path"] | |||
| ) | |||
|
|
|||
| file_partial_path = file_partial_path.lstrip("/") | |||
There was a problem hiding this comment.
Isn't this replaced by mistake?
This will replace all "/" in path but the lstrip will only remove the leading slash, which seems to be more correct to the fact that we want the partial path.
There was a problem hiding this comment.
oops yeah I did a search and replace and I didn't read the full thing, I only meant to change the ones for the proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of
lstripwithreplaceto removehttps://from proxy env as it was stripping extra characters as reported here https://community.ynput.io/t/shotgrid-addon-secrets-permissions-and-proxy-problems/1343/7